Batch non-mocked frontend test files#5
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Improves the frontend test runner (bun run test in frontend/) by introducing a deterministic “test run planning” helper that groups contiguous non-mock.module(...) test files into batched Bun test invocations, while still isolating mock.module users into their own Bun process to avoid cross-test interference.
Changes:
- Extracted test discovery + run planning logic into a new
run-tests-plan.tsmodule. - Updated the serial test runner to execute a sequence of planned runs (batched vs isolated) and print a more informative completion summary.
- Added focused unit tests covering deterministic test file collection,
mock.moduledetection, and batching behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/test/run-tests-serial.ts | Switches from per-file execution to executing planned runs (batch/isolated) using the new planner and prints updated progress/summary output. |
| frontend/src/test/run-tests-plan.ts | New helper for deterministic test file collection, mock.module detection, and batching/isolating logic. |
| frontend/src/test/run-tests-plan.test.ts | New unit tests validating file collection order, mock.module detection, and batching semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+45
to
+46
| const isolatedCount = runs.filter((run) => run.isolated).length; | ||
| const batchedCount = files.length - isolatedCount; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification